Repository navigation
feat: clarify topic-tree hierarchy and icon colors - #163
Conversation
Flatten the Sparkplug Devices wrapper into direct device siblings and color message types by owner: violet Router for node and gateway, amber for device. Keep green topic circles with no direct-message dots, and preserve open and closed folder states. Includes projection, rendering, icon language and test updates.
[Medium impact] The PR appears safe to merge; the previous test issue is addressed and no new blocking issues were found. SummaryThe PR places Sparkplug devices directly beneath their node and gives message types their owner's color.
|
This comment has been minimized.
This comment has been minimized.
|
Fixed both Greptile findings in 387f430. The outside-diff Sparkplug smoke tests and README now use direct device rows rather than the removed Devices wrapper, assert the flattened placement, and preserve device selection isolation and node membership checks. All 6 tests passed with --filter TestCategory=SparkplugGrouping (headless). The inline icon-key ID finding is fixed with per-instance stable IDs and two regression tests; I replied on and resolved its thread. Full solution build, unfiltered Core (1,795 passed, 1 skipped) and UI (1,845 passed, 1 skipped), formatting and repository gates passed. |
Summary
Validation
Closes #154
Closes #155
Closes #156