Add experimental Safari Apple Events adapter - #781
Draft
tompulsarlabs wants to merge 1 commit into
Draft
tompulsarlabs wants to merge 1 commit into
tompulsarlabs wants to merge 1 commit into
Conversation
Contributor
|
is keeping your existing Safari logins the main reason you built this? |
Author
Yeah and I tend to use Safari and Chrome equally. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari cannot use the current CDP path. This proposes an optional macOS
safari-harnesspackage underadapters/safarifor reading and interacting with existing Safari tabs through Apple Events. It provides familiar helper names, an agent skill, a disposable live fixture, and deterministic CI. The existing CDP runtime, package metadata, and skill are unchanged.Opening as a draft for feedback on the separate-adapter approach before deeper integration. The contribution contains the adapter, tests, and concise documentation; the fork's project bookkeeping is outside this diff.
Validation
Experimental limitations
Failed selection clears the previous target. Page JS also checks the exact URL before evaluating the requested expression, with executable Node regressions for redirects between validation and execution. That guard does not establish stable document identity: same-URL/title replacement, opaque origins sharing a URL, and native navigation races remain unresolved. Live adversarial race protection and agent/model-quality evaluations are unverified; consequential unattended writes remain outside the verified scope.
The adapter reports permission requirements, collects no recordings, and does not change Safari settings. Its README documents unsupported capabilities and opt-in live-test instructions.
Summary by cubic
Safari doesn't implement Chrome CDP, so this adds an optional
safari-harnesspackage underadapters/safarithat controls existing Safari tabs through macOS Apple Events. The existing CDP runtime, package metadata, and skill are unchanged; this is a draft to gather feedback on the separate-adapter approach.Experimental limitations
Validation
Written for commit 87b62ff. Summary will update on new commits.