Repository navigation
feat(js): buckaroo-js-core exports its own version - #1094
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.10.dev39494803321or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.10.dev39494803321MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.15.10.dev39494803321" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table📖 Docs preview🎨 Storybook preview |
The Release workflow runs npm version before the build, so the exported version is the one the bundle was released as. A consumer can compare it with the Python server's /health version and with what it pinned. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
paddymul
marked this pull request as ready for review
October 20, 2026 21:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
paddymul
added a commit
to buckaroo-data/tallyman
that referenced
this pull request
Oct 21, 2026
0.15.11 is the first release whose buckaroo-js-core exports its version (buckaroo-data/buckaroo#1094). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An app that bundles
buckaroo-js-corecannot ask the renderer it is running which version it is. The version lives inpackage.json, and a bundle carries only the code. tallyman pinsbuckaroo(the Python server) andbuckaroo-js-coreto the same version and has hit the failure that follows when they drift: a renderer older than the server does not send?caps=stats_update, so the server computes every summary stat before the first row and the grid is slow to appear, with no error. Checkingnode_modulesor a stamp file indistcan disagree with what the page actually runs. Asking the renderer cannot.Change
src/version.tsexportsversion, read frompackage.json, andindex.tsexposes it as a named export and on the default export.The Release workflow already runs
npm version <release> --no-git-tag-versionbeforepnpm run build, so a published bundle reports the version it was released as.package.jsonin the repo stays at 0.12.0, so a local build reports 0.12.0.Two build settings change because
src/version.tsimportspackage.json:tsconfig.jsonlistspackage.jsonininclude. Acompositeproject refuses an import of a file outside that list (TS6307), and vite-plugin-dts printed it as an error on every build.vite.config.tsstops vite-plugin-dts from writingdist/package.json.d.ts, which would otherwise hold the wholepackage.jsonas a type and ship in the package.versionis declared asstring, so the emitted.d.tsdoes not import../package.json, which is not published next todist/.Tests
src/version.test.tschecks thatversionequals thepackage.jsonversion, looks like a dotted version, and is also on the default export. It failed on CI before the fix commit (run 39493929890, JS / Build + Test: 3 failed, 371 passed). The red commit types the export loosely so thattscin the pre-commit hook passes and the failure is in the assertions. The fix commit switches to typed imports.Locally: the core jest suite passes (374 tests) and
pnpm run buildprints no diagnostics. The file list underdist/matches main's apart from the newdist/src/version.d.ts. Afternpm version 9.9.9 --no-git-tag-version,pnpm run buildputs"9.9.9"inindex.esm.js,index.es.jsandindex.cjs.js.Not in this PR: a release, and the tallyman side that compares this version with the server's
/healthversion and the version it pins.🤖 Generated with Claude Code