Repository navigation
Conversation
JonKuqi
marked this pull request as ready for review
August 25, 2026 13:51
JonKuqi
marked this pull request as draft
August 25, 2026 16:42
JonKuqi
marked this pull request as ready for review
August 26, 2026 15:27
PascalinDe
requested changes
Aug 27, 2026
PascalinDe
left a comment
Member
There was a problem hiding this comment.
requested some changes
for the rest, it looks good to me, but I think I'd like @ineiti to also have a look at it, as it is mostly his work
Member
|
Oh my - I have no idea anymore. Can we have a look at this after the UK? |
7 tasks done
Member
|
I created a PR #260 for some of the grpc references, but there are quite a lot left in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249
Changes
The CLI and integration setup now create MinoWS nodes using WebSocket multiaddresses and persistent libp2p keys. The obsolete certificate exchange, join tokens, routing flags, and TLS flags have been removed.
DKG state unmarshalling now receives the address factory from the active Mino instance:
Docker and local launch configurations now use MinoWS listen and public addresses. Proxy registration reads each node's complete runtime address so the generated
/p2p/<peer-id>component is preserved.D-Voting now uses DELA revision
08f5b05544f75c702aace49e316fb9004ee8f1fe.Also removed a duplicate registration because it was throwing errors. Go runs init() once before main, so the previous explicit call:
registered the same JSON engine a second time. runWithCfg() is called concurrently when CLI tests start several nodes, so the that second register produced data races in dela. The blank import "_ "github.com/c4dt/d-voting/services/dkg/pedersen/json" runs the package's init() exactly once.
Verification
The CLI, Pedersen DKG, integration, Docker, and system tests pass with MinoWS.