fix(admin): update aria-expanded and label when mobile menu is toggled - #714
Open
Ferryx349 wants to merge 3 commits into
Open
fix(admin): update aria-expanded and label when mobile menu is toggled#714Ferryx349 wants to merge 3 commits into
Ferryx349 wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: f019688 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR improves admin dashboard accessibility and keyboard handling by updating ARIA attributes on the mobile navigation toggle and refining which keypresses trigger global shortcuts.
Changes:
- Update
#menu-toggleto dynamically reflect drawer state viaaria-expandedand a statefularia-labelinsetNavOpen(). - Treat
<select>elements as “typing targets” to avoid triggering global shortcuts while interacting with form controls. - Ignore global shortcut handling when modifier keys (Meta/Ctrl/Alt) are pressed to prevent unintended actions (e.g., browser/system shortcuts).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cameri
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
aria-expanded(true/false) and dynamicaria-label(Open navigation/Close navigation) on#menu-toggleinsidesetNavOpen()so screen readers receive real-time navigation drawer state changes.Related Issue
Closes:- #712.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: