feat: add ps7 charm pack and deployment - #302
Open
muhammad-ali-pk wants to merge 1 commit into
Open
muhammad-ali-pk wants to merge 1 commit into
muhammad-ali-pk wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The PS7 workflow references a local action path that doesn’t exist (and the added deploy definition is placed where GitHub will treat it as an invalid workflow), which will break deployments.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new GitHub Actions-based packaging and deployment pipeline intended to build the charm and rock for this repo and deploy to ProdStack 7 (staging then production) using Juju + JAAS OAuth credentials.
Changes:
- Introduces a PS7 “Pack and Deploy” workflow that builds/caches the charm, builds/pushes a rock image to GHCR, then deploys to staging and production.
- Adds a Juju/JAAS deployment implementation intended to be reused by the workflow as a composite action.
File summaries
| File | Description |
|---|---|
| .github/workflows/ps7/pack.yaml | New workflow to pack charm/rock (with caching) and deploy to PS7 staging/production. |
| .github/workflows/ps7/deploy.yaml | New composite-style deploy definition for Juju/JAAS-based deployments (currently placed under workflows). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
muhammad-ali-pk
force-pushed
the
ps7-deployment
branch
4 times, most recently
from
September 10, 2026 11:03
d9c17ee to
6f2cc8c
Compare
muhammad-ali-pk
had a problem deploying
to
staging
September 10, 2026 12:13 — with
GitHub Actions
Failure
muhammad-ali-pk
force-pushed
the
ps7-deployment
branch
from
September 10, 2026 12:27
81b0ed2 to
48c045b
Compare
muhammad-ali-pk
had a problem deploying
to
staging
September 10, 2026 12:38 — with
GitHub Actions
Failure
muhammad-ali-pk
force-pushed
the
ps7-deployment
branch
from
September 10, 2026 12:52
48c045b to
d96bbe5
Compare
muhammad-ali-pk
had a problem deploying
to
staging
September 10, 2026 13:04 — with
GitHub Actions
Failure
muhammad-ali-pk
had a problem deploying
to
staging
September 23, 2026 12:38 — with
GitHub Actions
Failure
muhammad-ali-pk
had a problem deploying
to
production
September 23, 2026 12:56 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
[List of work items including drive-bys]
QA
./run serve.io/practices/workflow/qa-steps.html)
lved]
Issue / Card
Fixes WD-38516
Screenshots
[if relevant, include a screenshot]