Conversation
|
Thanks @Skazitron ! Looking at the "specs for dev" page in the Figma, the solution was to remove the spacing from the heading and the body, but maintain the spacing for the wrapper housing them: In the demo link you shared, I don't see this reflected Also looping in @kim-isaac, as she's the owner of the Figma, and maybe would like to take a look too :) |
|
Thanks for sharing @mattea-turic ! on’t have any other comments beyond what you’ve already mentioned. @Skazitron Based on Mattea’s comment, if metadata is included as well, the padding should be structured like this: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Done
QA
Card
https://warthogs.atlassian.net/browse/WD-37058
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention