Conversation
Replace all panic() calls in store/smt.go with proper error returns to prevent node crashes on corrupted data or database errors. Changes: - getOtherChild(): returns error instead of panicking when child not found - replaceChild(): returns error instead of panicking when child not replaced - initializeTree(): returns error instead of panicking on DB write failures - NewSMT(): returns error from initializeTree() instead of panicking - NewDefaultSMT(): propagates error from NewSMT() - Update all callers in store.go and smt_test.go This ensures the node handles corrupted Merkle tree data gracefully rather than crashing with an unrecoverable panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SMT (Sparse Merkle Tree) implementation in
store/smt.gousespanic()in 5 places for conditions that should return errors. In a production blockchain node, these panics cause an unrecoverable crash when encountering corrupted data or database errors.Changes
getOtherChild()(line 1156)ErrChildNotFounderrorreplaceChild()(line 1167)ErrChildNotReplacederrorinitializeTree()(line 481)NewSMT()(line 154)getNode()error and callsinitializeTree()without error handlingNewDefaultSMT()(line 149)NewSMT()New Error Types
Added to
store/error.go:ErrChildNotFound(childKey string)- for missing child nodesErrChildNotReplaced(oldKey string)- for failed child replacementsImpact
Testing
go build ./store/...