Conversation
Added overflow check before converting uint64 add value to int. Previously, if add was very large (close to math.MaxUint64), the conversion to int could overflow, causing the subsequent bounds check to fail. Now checks if add > math.MaxInt64 before conversion and returns ErrMaxPort() if it would overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AddToPort()converts auint64value tointwithout checking for overflow:If
addis very large (close tomath.MaxUint64),int(add)would overflow to a negative number, causing the subsequent bounds check to fail.Fix
Added overflow check before the conversion:
Impact
addvalue → integer overflow → incorrect port calculationaddvalue → returnsErrMaxPort()error