SP-1173: extend CUI marking to exported archives - #411
Open
Dennis Woditsch (dwoditsch) wants to merge 4 commits into
Open
SP-1173: extend CUI marking to exported archives#411Dennis Woditsch (dwoditsch) wants to merge 4 commits into
Dennis Woditsch (dwoditsch) wants to merge 4 commits into
Conversation
…chives writeToFileWithGivenName serializes a payload into a fresh archive, which would nest a zip inside a zip for commands whose artifact is already one. writeZipToFileWithGivenName takes the archive bytes instead and adds the cover sheet alongside the existing entries, keeping the same three outcomes: original name, "Unclassified - " prefix, or "CUI - <name>.zip". Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Route the five writers whose artifact is a single zip through writeZipToFileWithGivenName: config package export --zip, config branch export --zip, t2tc package export, export action-flows and the deprecated pull package. writeLocalArtifact, downloadZip and BaseManager.pullFile become async so they can await the marking decision; pullFile drops its Promise wrapper for plain async/await. writeStreamToFile also picks up the resolve(process.cwd(), ...) it was missing, matching every other writer. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
One case per archive writer, asserting the logged name is the classified archive and that it holds the original entries plus the cover sheet. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Dennis Woditsch (dwoditsch)
force-pushed
the
feat/SP-1173-cui-marking-zip-exports
branch
from
August 10, 2026 12:14
9b1567c to
4496b86
Compare
Both entry points repeated the cover fetch and the unmarked and unclassified branches, differing only in the classified outcome. writeWithCoverHandling owns the decision and takes that outcome as a callback; writePayload picks the fileService method for the payload it is given and returns the name it wrote. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
|
Nikolai Fischer (nikolai-celonis)
approved these changes
Aug 10, 2026
Dennis Woditsch (dwoditsch)
marked this pull request as ready for review
August 11, 2026 05:27
3 tasks
Alexander Probst (alex-probst)
approved these changes
Aug 11, 2026
Nikolai Fischer (nikolai-celonis)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #410, which finished the
-o, --outputToJsonFilerow. This PR marks the exports whose artifact is already a single zip: the cover sheet goes into the archive the command produced, not into a new one wrapped around it.That settles the "already a zip" question #405 left open, so only the directory row stays undecided.
Scope: how the write is triggered
--jsonlistings and reportslist spaces,list packages--jsonlistings and reportslist assets/assignments/data-pools,config *,t2tc package list/diff,deployment *,asset-registry *-o, --outputToJsonFilereportsanalyze/import action-flows,export data-pool,import data-pools,t2tc package importreportconfig package export --zip,config branch export --zip,t2tc package export,export action-flows,pull packagepull asset/skill/data-pool/view-bookmarks/bookmarks,export bookmarksconfig package export,config branch export,t2tc package export --unzip--gitBranchvariantsconfig package export,config branch export,t2tc package exportRelevant links
Checklist
Made with Cursor