Repository navigation
Compose UI migration - #3196
Open
HrBDev wants to merge 75 commits into
Open
Compose UI migration #3196HrBDev wants to merge 75 commits into
HrBDev wants to merge 75 commits into
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 604 files, which is 304 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
📒 Files selected for processing: 604
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
Worth a look — the grounded gate found no coupling regressions or blocking issues, but 1 advisory finding(s) below merit a look before merge.
Not checked: tests were not run; no formal proof of the changed code.
Graphify review — findings
Hardens the app's Gradle build: getVersionCode now takes VERSION_CODE from the environment whenever it is set, otherwise from the Gradle property, and fails the build with a GradleException unless the value is a positive integer, instead of silently defaulting to 0. Moves the plugin aliases, SDK levels and Kotlin language version into the version catalog, and switches the release, alpha and releaseDebug build types to the optimization { enable = true } DSL. Drops view binding and the viewbindingpropertydelegate libraries, swaps Konfetti XML for Konfetti Compose, and shares the Compose dependencies across flavors instead of keeping a TV-only BOM.
Worth a look
- Empty VERSION_CODE env var no longer falls back to the Gradle property —
app/build.gradle.kts:109· Escalate · medium- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 7259 functions depend on the 5900 functions this change touches.
Health — this change adds coupling hotspots:
- new:
utilityTextStyle()— 81 callers, 11 callees - new:
themeColor()— 235 callers, 3 callees - new:
NetworkContent()— 7 callers, 23 callees - new:
OriginalCardSurface()— 12 callers, 11 callees - new:
SummaryStatisticsScreen()— 8 callers, 16 callees - new:
DnsEndpointRow()— 20 callers, 6 callees - new:
RpnConfigContent()— 9 callers, 13 callees - new:
WgText()— 23 callers, 5 callees - …and 139 more — each is listed as a finding
Verification — 7259 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 7085 function(s) in the blast radius were not formally verified this run
HrBDev
force-pushed
the
refactor/compose-ui-clean-history
branch
from
October 15, 2026 22:31
7b3eccc to
64ced3e
Compare
Collaborator
|
@HrBDev I was also working on the Compose migration in my local branch. I’d be glad to accept the PR, and hopefully with an even more expressive and polished UI :) |
Contributor
Author
I tried to keep the UI the same in this migration, with almost no visible changes. Please merge #3145 first; I fixed the conflicts, and this PR is based on that. |
HrBDev
force-pushed
the
refactor/compose-ui-clean-history
branch
from
October 18, 2026 14:23
64ced3e to
f9f7ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.