Feat/embed filepicker - #249
Open
diocas wants to merge 8 commits into
Open
Conversation
diocas
marked this pull request as ready for review
June 5, 2026 06:37
Gerry-Cern
approved these changes
Jun 9, 2026
Gerry-Cern
left a comment
Gerry-Cern
left a comment
There was a problem hiding this comment.
LGTM, fixed some small bugs and added some unit test.
diocas
force-pushed
the
feat/embed_filepicker
branch
from
June 17, 2026 11:17
3a5b0e1 to
938cb1a
Compare
diocas
force-pushed
the
feat/embed_filepicker
branch
from
June 30, 2026 09:58
938cb1a to
8a79585
Compare
To allow them to be downloaded without the user token.
Allows embeding the UI and delegating the attach action (via a post message). Users have to select files, and the application will then ask cernbox to return the list of files selected with the respective download urls.
Since folders cannot be downloaded, it prevents their selection to make it clear to users.
…on embed mode. Update tests to ensure correct message posting behavior and add checks for file selection in embed mode.
diocas
force-pushed
the
feat/embed_filepicker
branch
from
July 6, 2026 13:07
8a79585 to
b9e42a7
Compare
The embedded web instance used by FilePickerModal.vue posts the picked resource back to the parent as-is. On backends that don't return downloadURL via WebDAV PROPFIND, that field is simply absent, and downstream consumers (e.g. web-app-external's insertGraphic/insertFile) had to work around it with a second webdav.getFileInfo round-trip. Adds useEmbedModeDownloadUrl, mirroring EmbedActions.vue's existing withSignedUrls (used by the location-picker "Select" flow, gated on capabilityStore.supportUrlSigning, same signing call as useDownloadFile.ts's regular download button) but scoped to a single resource and applied to the file-pick flow that never had it: ResourceTable.vue's fileClicked and ResourceTiles.vue's emitTileClick now sign the clicked resource before posting owncloud-embed:file-pick, if and only if downloadURL isn't already present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New embedded mode to replace the current file picker that we expose to Indico and CodiMD.
Made changes to try to be as close as the current implementation but still needs to be tested.