Jenkinsfile: Now checks out ref names instead of pinned commits - #2468
Draft
larsewi wants to merge 1 commit into
Draft
Jenkinsfile: Now checks out ref names instead of pinned commits#2468larsewi wants to merge 1 commit into
larsewi wants to merge 1 commit into
Conversation
GitHub replaces refs/pull/N/merge every time the pull request is pushed to. A build that had already pinned the old merge commit could then no longer check it out. The other Jenkins jobs pass the ref name to git and let each node resolve it, so do that here too. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub replaces refs/pull/N/merge every time the pull request is pushed to.
A build that had already pinned the old merge commit could then no longer
check it out.
The other Jenkins jobs pass the ref name to git and let each node resolve
it, so do that here too.
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech