Skip to content

Feature: Allow configuring Helm hook weight via values #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jemsz95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature: Allow configuring Helm hook weight via values #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/chatwoot/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ sources:
- http://www.chatwoot.com

# This is the chart version.
version: 2.0.23
version: 2.0.24


# This is the application version.
Expand Down
2 changes: 1 addition & 1 deletion charts/chatwoot/templates/migrations-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ metadata:
# job is considered part of the release.
"helm.sh/hook": {{ .Values.hooks.migrate.hookAnnotation }}
"helm.sh/hook-delete-policy": "hook-succeeded,before-hook-creation"
"helm.sh/hook-weight": "-1"
"helm.sh/hook-weight": {{ .Values.hooks.migrate.hookWeight | quote }}
spec:
template:
spec:
Expand Down
1 change: 1 addition & 0 deletions charts/chatwoot/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ hooks:
# Defaults to performing the DB migration job after the install/upgrade.
# Can be overridden to "pre-install,pre-upgrade" with caution to perform migrations that are sometimes required for the deployment to become healthy
hookAnnotation: "post-install,post-upgrade"
hookWeight: -1
Comment thread
jemsz95 marked this conversation as resolved.

# ENVIRONMENT VARIABLES

Expand Down
Loading