Repository navigation
feat: add topology spread constraints for web and worker pods - #210
hazem-nasser2 wants to merge 4 commits into
Conversation
Added topology spread constraints for web and worker pods.
Added topology spread constraints to web deployment.
Add topologySpreadConstraints to worker deployment
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb39ec54ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| replicaCount: 1 | ||
| # Topology spread constraints for web pods | ||
| # Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ | ||
| topologySpreadConstraints: [] |
There was a problem hiding this comment.
When this change is merged to main, the release workflow invokes chart-releaser (.github/workflows/release.yaml, lines 31-34), but charts/chatwoot/Chart.yaml remains at the already released version 2.0.24. Without a new chart version, no package containing these topology-spread settings will be published, so users installing or upgrading from the repository cannot use the feature. Increment the chart version alongside this change.
Useful? React with 👍 / 👎.
|
@vishnu-narayanan Hi maintainers, could someone please review this PR when available? It adds optional topologySpreadConstraints support for the web and worker deployments. The change is backward-compatible, defaults to no topology constraints, and all chart lint/tests are passing. Thanks! |
This branch has not been deployed
1 participant
feat: add topology spread constraints for web and worker pods