Repository navigation
Add support for aarch64 macos firtool binaries - #34
Merged
Merged
Conversation
seldridge
approved these changes
Apr 9, 2026
|
|
||
| case class Platform(os: String, arch: String) { | ||
| override def toString: String = s"$os-$arch" | ||
| // CIRCT release artifacts use "arm64" but FNDDS uses "aarch64" |
Collaborator
Author
There was a problem hiding this comment.
Why, it's the Firtool Native Dependency Distribution Specification of course!
https://github.com/chipsalliance/firtool-resolver?tab=readme-ov-file#firtool-native-dependency-distribution-specification-fndds
I picked aarch64 over arm64 for that because it's what the JVM distributions use and that seemed as as good as reason as any 🤷♀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They will now be required by FindNewReleases for CD, but the firtool-resolver logic will still support falling back to x64 on macos aarch64 because users could use older versions of
llvm-firtoolthat did not have the macos aarch64 binary available.