Skip to content

Skip vmulh/vsmul SEW=64 tests on Zve64-only targets - #89

Merged
ksco merged 1 commit into
chipsalliance:mainfrom
nadime15:fix/zve64-sew64-mulh
May 6, 2026
Merged

ksco merged 1 commit into
chipsalliance:mainfrom
nadime15:fix/zve64-sew64-mulh

Conversation

@nadime15

@nadime15 nadime15 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Per V spec, vmulh.{vv,vx}, vmulhu.{vv,vx}, vmulhsu.{vv,vx} and vsmul.{vv,vx} are not available at EEW=64 in Zve64*. Spike commit d1e34d0 enforces this, which broke the v64x64 build (no full V at VLEN=64).

Add an Option.HasV flag derived from the march string and skip SEW=64 generation for these eight instructions when V is absent.

Surfaced in #87 while bumping the Spike version.

Additionally update Spike to latest commit.

Per V spec, vmulh.{vv,vx}, vmulhu.{vv,vx}, vmulhsu.{vv,vx}
and vsmul.{vv,vx} are not available at EEW=64 in Zve64*. Spike
commit d1e34d0 enforces this, which broke the v64x64 build (no
full V at VLEN=64).

Add an Option.HasV flag derived from the march string and skip
SEW=64 generation for these eight instructions when V is absent.

Surfaced in chipsalliance#87 while bumping the Spike version.

Additionally update Spike to latest commit.

Co-authored-by: Jean-Michel Gorius <jmgorius@users.noreply.github.com>
@nadime15

nadime15 commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@jmgorius This PR should address the issue you encountered in #87. Thanks for bisecting, it helped narrow down the problem quickly!

@jmgorius

jmgorius commented May 6, 2026

Copy link
Copy Markdown
Contributor

Nice! I didn't have much time to look into the issue on my side, glad you figured it out!

@ksco
ksco merged commit b30515e into chipsalliance:main May 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants