Repository navigation
Conversation
…m formats The SEW list for these two formats was truncated unconditionally, so the sew64 blocks declared in their configs were generated for no instruction that does not widen. 19 instructions were affected across the two files. vd,vs2,uimm,vm: only .wi widens vs2 and only vw* widens vd; with neither, SEW=64 is legal and must be tested. The previous unconditional -1 dropped it for the non-widening forms (vsll.vi, vsra.vi, vssra.vi, vror.vi, ...). vd,vs2,vm: 'float' was computed but never consulted, so the integer members of the format (vbrev.v, vbrev8.v, vclz.v, vcpop.v, vctz.v, vrev8.v) were handed the float SEW list and never tested at SEW=8, which they declare and which is legal. Fixes chipsalliance#94
cwssemi
marked this pull request as ready for review
August 25, 2026 13:57
Author
|
Also run with #97 applied, https://github.com/cwssemi/riscv-vector-tests/actions/runs/32840864176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the
sew64blocks that these two formats' configs already declare.vd,vs2,uimm,vmtruncated the SEW list unconditionally:The
-1on the non-widening arm drops SEW=64 for every member that does not widen. Only.wiwidensvs2and onlyvw*widensvd; with neither, SEW=64 is legal and the configs declare values for it.So
vsll.vi,vsra.vi,vssra.vi,vror.viand the rest were never generated at SEW=64.vd,vs2,vmcomputesfloatand then never consults it:so the integer members of the format —
vbrev.v,vbrev8.v,vclz.v,vcpop.v,vctz.v,vrev8.v— get the float SEW list and are never tested at SEW=8, which they declare and which islegal for them.
19 instructions across the two files. The fix keeps the widening arms exactly as they were and only
restores the non-widening/integer arms.
Why it matters beyond the count
The dropped dimension is not neutral: SEW=64 is where 32-bit-truncation defects live. Running these
configs against a production RVV implementation once the dimension was restored surfaced two
silent-wrong-result defects at SEW=64 that the truncated matrix passes on — one an immediate-decode
defect on
vror.vi, one a saturation-bound defect onvsmul.Fixes #94