Repository navigation
Conversation
The package-level strings.Replacer is built during package initialization, which happens on every start of any program importing cilium/ebpf (even indirectly, e.g. via asm), regardless of whether mountinfo is ever parsed. Use sync.OnceValue to only create it when needed. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
My bad; strings.NewReplacer is actually lazy by itself, so this is not needed at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package-level
strings.Replaceris built during package initialization, which happens on every start of any program importing cilium/ebpf (even indirectly, e.g. viaasm), regardless of whether mountinfo is ever parsed.Use
sync.OnceValueto only create it when needed.This reduces
internal/mountinfoinit time from about 5µs to 1µs (measured withGODEBUG=inittrace=1on runc, which re-executes itself for every container start/exec).