Skip to content

[NFC] afform: add comment about StringVisitor being embedded into civistrings - #34264

Merged
eileenmcnaughton merged 1 commit into
civicrm:masterfrom
mlutfy:afformVisitorComment
Dec 11, 2025
Merged

eileenmcnaughton merged 1 commit into
civicrm:masterfrom
mlutfy:afformVisitorComment

Conversation

@mlutfy

@mlutfy mlutfy commented Dec 11, 2025

Copy link
Copy Markdown
Member

Overview

Related to: civicrm/civistrings#18

Document that this file is being copied into another project.

@civibot

civibot Bot commented Dec 11, 2025

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the master label Dec 11, 2025
@eileenmcnaughton
eileenmcnaughton merged commit e95ab0c into civicrm:master Dec 11, 2025
1 check passed
@eileenmcnaughton
eileenmcnaughton deleted the afformVisitorComment branch December 11, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants