Repository navigation
mgd.php extractor add empty_value and rewrite support - #27
Merged
Merged
Conversation
Contributor
|
@samuelsov is this one that @mlutfy is reviewing? |
Contributor
Author
|
After discussing with @mlutfy, it seems that the test for The example given by @colemanw is already excluded from translation because it contains 'rewrite' => '<b>{ts}Summary:{/ts}</b> [description]<br><b>{ts}Details:{/ts}</b><pre>[data]</pre>',So it's probably better to remove the extra check to exclude |
samuelsov
force-pushed
the
skextractor
branch
2 times, most recently
from
June 10, 2026 21:48
87c7eb8 to
b92e2b6
Compare
Contributor
Author
|
@mlutfy Fixed as discussed and added a small fix by coleman on isWorthy. So it should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on:
Add to mgd.php extractor
empty_valueandrewritesupport as per https://github.com/civicrm/civicrm-core/pull/35860/changes#discussion_r3356537282Also, the
isWorthyis updated to be more restrictive the same way we do in https://github.com/civicrm/civicrm-core/pull/35795/changes#diff-28f92e8856eeed4876a3db8314849540334b78d799fcce9411d2be34a021b51fR84