Skip to content

mgd.php extractor add empty_value and rewrite support - #27

Merged
colemanw merged 1 commit into
civicrm:masterfrom
samuelsov:skextractor
Jun 15, 2026
Merged

colemanw merged 1 commit into
civicrm:masterfrom
samuelsov:skextractor

Conversation

@eileenmcnaughton

Copy link
Copy Markdown
Contributor

@samuelsov is this one that @mlutfy is reviewing?

@samuelsov

Copy link
Copy Markdown
Contributor Author

After discussing with @mlutfy, it seems that the test for html type is rather unnecessary as we we want to be able to translate pure html like:

<h2>This is my <b>important title</b></h2>

The example given by @colemanw is already excluded from translation because it contains {ts}
https://github.com/civicrm/civicrm-core/pull/35860/changes#diff-d24b221e2b30a568dc91748b1b2dd42a3f6bf09c5b85d2701e31651c232954d0R88

'rewrite' => '<b>{ts}Summary:{/ts}</b> [description]<br><b>{ts}Details:{/ts}</b><pre>[data]</pre>',

So it's probably better to remove the extra check to exclude rewrite if type=html.

@samuelsov
samuelsov force-pushed the skextractor branch 2 times, most recently from 87c7eb8 to b92e2b6 Compare June 10, 2026 21:48
@samuelsov

Copy link
Copy Markdown
Contributor Author

@mlutfy Fixed as discussed and added a small fix by coleman on isWorthy. So it should be good to go.

@colemanw
colemanw merged commit 5c14211 into civicrm:master Jun 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants