Skip to content

feat: add monochrome recording overlay toggle - #2105

Closed
rajin-khan wants to merge 3 commits into
cjpais:mainfrom
rajin-khan:feat/monochrome-recording-overlay
Closed

rajin-khan wants to merge 3 commits into
cjpais:mainfrom
rajin-khan:feat/monochrome-recording-overlay

Conversation

@rajin-khan

@rajin-khan rajin-khan commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Before Submitting This PR

Human Written Description

while i do love the brand colors and aesthetic, a little monochrome customization for taste would be really nice to have. it wouldnt make it stand out and really blend in with everything

Related Issues/Discussions

This revisits only the overlay-color portion of #551. That PR was closed because it also changed the app-wide brand colors; the maintainer said a muted, monochrome overlay and a narrower overlay-style PR could be considered. Discussion #1212 asks for a white accent and has supporting replies.

Community Feedback

See #1212 and the maintainer's comments on #551. The request in #1212 is broader than this PR, which limits the option to the recording overlay. A separate toggle applies the color choice to both Minimal and Live.

Testing

  • git diff --check passed.
  • English translation JSON parsed successfully.
  • Static wiring check confirmed the new toggle is present in the Rust setting and command, TypeScript binding and settings UI, and both overlay variants. The i18n configuration falls back to English for untranslated labels.
  • Static check confirmed that changing the color toggle emits an event to the overlay webview, where the listener updates the visible card and cleans up on unmount.
  • Calculated monochrome accent contrast against the underlying light and dark palette backgrounds: 7.67:1 and 7.85:1. The overlay surface is 98% opaque, so these are approximate rendered values.
  • Handy build and runtime checks remain unverified because Bun and Rust are not installed on this Mac.

Screenshots/Videos (if applicable)

Not available yet; a local Handy build is needed to capture the native overlay.

AI Assistance

  • AI was used.
  • Tools used: Codex.
  • How extensively: Codex prepared the code, inspected the existing overlay architecture, and ran static checks. The human contributor supplied the Human Written Description above.

@rajin-khan
rajin-khan marked this pull request as ready for review September 18, 2026 18:50
Copilot AI lite review requested due to automatic review settings September 18, 2026 18:50
@rajin-khan
rajin-khan marked this pull request as draft September 18, 2026 18:52
@rajin-khan
rajin-khan marked this pull request as ready for review September 18, 2026 18:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Changing the style while an overlay is visible persists the setting but does not update the active overlay until the next session.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a persisted monochrome compact recording-overlay style.

Changes:

  • Adds the Monochrome setting and translations.
  • Extends Rust and TypeScript overlay-style handling.
  • Applies neutral accent colors to the compact overlay.
File summaries
File Description
src/overlay/RecordingOverlay.tsx Applies monochrome state to the overlay.
src/overlay/RecordingOverlay.css Defines monochrome color tokens.
src/i18n/locales/en/translation.json Adds the option and description.
src/components/settings/ShowOverlay.tsx Adds the settings dropdown option.
src/bindings.ts Updates the frontend overlay-style type.
src-tauri/src/shortcut/mod.rs Parses the new style.
src-tauri/src/settings.rs Adds the persisted enum variant.
src-tauri/src/actions.rs Routes monochrome to the compact overlay.
Review details
  • Files reviewed: 8/8 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/overlay/RecordingOverlay.tsx Outdated
@rajin-khan rajin-khan changed the title feat: add monochrome compact overlay style feat: add monochrome recording overlay toggle Sep 18, 2026
@cjpais

cjpais commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Sorry, this is not being pulled in, for people who want these features, they can put them on a fork

Also, no screenshot was submitted for a visual change, so I don't have time to build this myself and then check it out, but as far as I can tell based on the description, this is a visual change that is a personal preference and this app largely does not support personal preferences, only broad community support

@cjpais cjpais closed this Sep 19, 2026
@rajin-khan

Copy link
Copy Markdown
Contributor Author

Fair, thanks for building this though, it's great!

@cjpais

cjpais commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Thank you! And really appreciate your understand and excitement and thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants