feat: post-processing profiles with their own shortcuts - #2149
Closed
VitoMakarevich wants to merge 1 commit into
Closed
VitoMakarevich wants to merge 1 commit into
VitoMakarevich wants to merge 1 commit into
Conversation
One post-processing setup is limiting when different tasks want different models, e.g. a local model for quick cleanup and cloud models for heavier rewriting. Profiles make each setup a tab with its own global shortcut. - Each profile is a full copy of the existing post-processing settings (provider, base URL, API key, model, prompts); the pipeline is unchanged. - Tabs on the Post Processing page: + adds, x deletes, double-click renames. - The existing configuration migrates into an undeletable Default profile that keeps the original shortcut (settings schema 3). - The processing overlay names the profile in use. - History records the profile (migration 5 backfills Default); retry reuses it, and skips post-processing if that profile was deleted. - New strings translated for all locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Human Written Description
Adds post-processing profiles: add/delete/update profiles, each identical to what was there before (keybinding / backend / prompts) — no changes to how post-processing itself works. The name of the profile being used is shown while post-processing, all new text is localized, and retrying a history entry falls back to no post-processing if its profile was deleted.
Profiles are managed with a tabs interface on the Post Processing page: + adds a tab, × deletes it, and double-clicking a tab title renames it.
So the process of using multiple profiles is:
E.g. I use one for local qwen, one for gpt-6-luna and one for gpt-6-sol, and assign F5/F6/F7 to them.
Why this should be reconsidered
Migration
The current setup moves into an undeletable Default profile:
post_process_*settings (provider, base URL, API keys, models, prompts, selected prompt) become the Default profile, which keeps the existing "Transcribe with post-processing" shortcut, so nothing needs reconfiguring.--toggle-post-processandSIGUSR1trigger Default.post_process_profile_id; existing post-processed entries are assigned to Default. Deleting a profile clears the id on its entries (app-levelON DELETE SET NULL, since profiles live in the settings store), and retrying such an entry skips post-processing instead of sending it to another provider.Related Issues/Discussions
Previously closed:
Related discussions:
Discussion: TODO (author): link the discussion with community support.
Community Feedback
TODO (author): link community feedback.
Testing
cargo test: 290 passing, including new tests for the settings migration, profile add/rename/delete invariants, recovery from a malformed profile, profile resolution by shortcut, the history migration backfill,ON DELETE SET NULL, and retry routing.tsc,eslint,check:translations(all locales),prettier/cargo fmtclean.Screenshots/Videos (if applicable)
TODO (author): screenshot of the profile tabs.
AI Assistance
If AI was used: