Skip to content

fix(openstack): correct cloud config template for dynamic networks and disk types - #68

Merged
neddp merged 2 commits into
masterfrom
fix-openstack-cloud-config-template
Sep 10, 2026
Merged

neddp merged 2 commits into
masterfrom
fix-openstack-cloud-config-template

Conversation

@neddp

@neddp neddp commented Sep 10, 2026

Copy link
Copy Markdown
Member
  • Move range/reserved/static/gateway inside manual-only guard so dynamic networks don't emit range: null
  • Replace hardcoded gp2 disk type default with empty cloud_properties when no volume_type is set (gp2 is AWS-specific; OpenStack uses Cinder default)
  • Fix README comment: volume_type has no default for OpenStack

…d disk types

- Move range/reserved/static/gateway inside manual-only guard so dynamic
  networks don't emit `range: null`
- Replace hardcoded `gp2` disk type default with empty cloud_properties
  when no volume_type is set (gp2 is AWS-specific; OpenStack uses Cinder default)
- Fix README comment: volume_type has no default for OpenStack
@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a5876a81-2c0a-4745-a2bb-4bb5c529668b

📥 Commits

Reviewing files that changed from the base of the PR and between 252eb20 and 24a22dd.

📒 Files selected for processing (2)
  • README.md
  • templates/cloud_config_openstack.yml.erb

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The OpenStack cloud configuration template now emits azs for every subnet and limits range to manual networks. Disk types use the configured volume_type; when it is absent, the template emits empty cloud_properties instead of defaulting to gp2. The README now documents that the CPI/Cinder default applies when volume_type is unspecified.

Merge Risk: ⚪ Minimal · up to 24a22

The OpenStack configuration updates correctly scope manual-network fields and let Cinder use its default volume type when none is configured. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the OpenStack cloud configuration fixes for dynamic networks and disk types. It accurately summarizes the main changes.
Description check ✅ Passed The description directly explains each change in the pull request, including the manual-network guard, the removal of the hardcoded gp2 default, and the README correction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-openstack-cloud-config-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Sep 10, 2026
@neddp
neddp merged commit 4aa432d into master Sep 10, 2026
10 checks passed
@neddp
neddp deleted the fix-openstack-cloud-config-template branch September 10, 2026 09:25
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants