Remove scheduler_hint and ephemeral_disk from CreateVM Struct

[Sascha222]

Remove unimplemented ephemeral_disk and scheduler_hints from CreateVM

The Go CPI's CreateVM struct declared ephemeral_disk and scheduler_hints fields that were parsed from cloud properties but never read or acted upon anywhere in the codebase. This gave operators false confidence that setting these properties would have an effect, when in reality they were silently ignored.

Error:
Operators configuring ephemeral_disk or scheduler_hints in their cloud config would see the properties accepted without error, but the CPI would not apply them during VM creation — no ephemeral Cinder volume would be attached, and no scheduler hints would be passed to OpenStack.

Changes:

• Removed EphemeralDisk field from the CreateVM struct in create_vm_cloud_props.go
• Removed SchedulerHints field from the CreateVM struct in create_vm_cloud_props.go
• Properties will now fail validation if specified, making it clear they are not supported rather than silently ignoring them

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 8ff20fc8-ab3b-47b8-ae0a-6d5b09e67958

📥 Commits

Reviewing files that changed from the base of the PR and between 2395905 and e1cfd79.

📒 Files selected for processing (1)

• src/openstack_cpi_golang/cpi/properties/create_vm_cloud_props.go

💤 Files with no reviewable changes (1)

• src/openstack_cpi_golang/cpi/properties/create_vm_cloud_props.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The CreateVM struct no longer declares the ephemeral_disk or scheduler_hints fields. Its instance_type, key_name, loadbalancer_pools, and root_disk fields remain.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e1cfd

The field removal matches the intended cleanup, and no affected Go callers were found. The change is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the BOSH-2087 change and names both removed items: scheduler hints and ephemeral disk.
Description check	✅ Passed	The description links to BOSH-2087, which matches the pull request title and the removal of the scheduler_hints and ephemeral_disk fields.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}