Add condition parameter for containerWait - #97
Open
abretschneider wants to merge 1 commit into
Open
Conversation
abretschneider
force-pushed
the
add-condition-parameter-for-container-wait
branch
from
July 27, 2026 15:18
00c8e31 to
f7cf661
Compare
abretschneider
force-pushed
the
add-condition-parameter-for-container-wait
branch
from
July 27, 2026 15:41
f7cf661 to
480f8de
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates the Docker client wrapper to support the Docker Engine ContainerWait API’s optional condition query parameter, enabling callers to wait for specific container state transitions.
Changes:
- Extend
Client::containerWait()with an optional$conditionargument and pass it asconditionin the request URI when provided. - Add a unit test covering
containerWait()withcondition=next-exit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/ClientTest.php | Adds test coverage for containerWait() when passing the condition query parameter. |
| src/Client.php | Adds optional $condition parameter to containerWait() and includes it in the URI template expansion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Block until container id stops, then returns the exit code | ||
| * | ||
| * @param string $container container ID | ||
| * @param string $condition Wait until a container state reaches the given condition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
containerWaithttps://docs.docker.com/reference/api/engine/version/v1.40/#tag/Container/operation/ContainerWait API supports aconditionparameter which is not pass in the Client yet.Add it as a method parameter and pass it if set.