Cobbler v4.0.0b5 updates - #96
Merged
Merged
Conversation
SchoolGuy
force-pushed
the
feature/cobbler-4-0-0-b4
branch
2 times, most recently
from
August 27, 2026 19:59
5046adf to
037f0fb
Compare
Cobbler 4.0.0b5 changed get_item/get_<type> and remove_item/remove_<type> to require an object uid instead of a name. Bump cobblerclient to v1.0.0-rc5 (which already made this change) and adapt: - Add a resolveUID(client, what, name, uid) helper (cmd/item.go) that returns uid directly if given, else resolves name via FindItems, erroring clearly on zero or ambiguous matches. - Add a sibling --uid flag (addUIDFlag) to every remove/report/export/ rename/copy/edit/dumpvars/get-autoinstall/power-*/reboot/content subcommand across all item types, alongside the existing --name flag - both keep working, resolveUID bridges whichever is given into the uid the client now requires. - report/export now use the bulk Get<Type>s() call when no --name/--uid is given, instead of N per-item round trips. - Bump testing/start.sh's cobbler_image_tag to v4.0.0b5. - Add live-server coverage for cmd/distro_group.go, profile_group.go, system_group.go, template.go, and interface.go, filling the gap that left this PR's --uid/--name plumbing (resolveUID call sites, Get/Delete/Copy call-site wiring) untested and failing the diff-coverage gate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SchoolGuy
force-pushed
the
feature/cobbler-4-0-0-b4
branch
from
August 27, 2026 20:31
037f0fb to
1635780
Compare
Round 3 of the diff-coverage push: adds the menu.go --uid test file that round 2 missed, backfills copy/edit/rename/remove/report/export --uid and "report all"/"export all" cases across distro/profile/image/repo/system, adds dumpvars/get-autoinstall/power command coverage for profile and system, exercises the full interface-type and template-schema flag switches in interface.go/template.go, and adds --items coverage for the shared group_common.go code path across all three *_group.go commands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the CLI for the changes that were introduced in the backend with v4.0.0b4 and v4.0.0b5:
remove_itemandget_itemrequire UIDs now