refactor(featureflags): remove launched beta flags - #1179
Open
bmc08gt wants to merge 4 commits into
Open
Conversation
The following flags shipped (launched = true) and already returned true unconditionally at runtime, so inline them as always-on and delete the now-dead disabled branches: WelcomeBonusBill, Pools, OnRamp, BillCustomizer, CurrencyCreator, CashReserves, MarketCapChart, CoinbaseOnRamp, TokenDiscovery, DepositUsdc, PhoneNumberSend, OnboardingPhoneVerification, Messenger, AddMoneyUX. - Collapse constant flag state into defaults and remove the observe/event/reducer plumbing (e.g. depositFirstUx, marketCapChartEnabled, createEnabled, isPhoneNumberSendEnabled, addMoneyUx) and propagate the always-on value into UI. - Drop the dead server-flag OR (flag || enablePhoneNumberSend) that was always true, and remove RealChatCoordinator's now-redundant flag observer / isChatEnabled. - Remove FeatureFlagController dependencies left unused after inlining, plus the orphaned description_noBalanceYetDiscover string. Behavior-preserving: each flag already evaluated to true for all users.
Delete the 14 shipped (launched = true) flag data objects and their title/message entries now that all call sites treat them as always-on. Remaining flags are the genuinely in-flight ones (CredentialManager, VibrateOnScan, TransactionDetails, CoinbaseOnRampSandbox, BillTextures, BackgroundReset, ContactPickerMode, GiveUsdf, NavBar, ShowNetworkState, Tipping, FrostedTipCard, Blocklist).
github-actions
Bot
added
type: refactor
LoginViewModel, SwapViewModel and RealChatCoordinator no longer take a FeatureFlagController after the launched-flag inlining, so their existing tests no longer compile. Remove the stale constructor argument.
Lock in the always-on behaviour left behind by the removed flags: - BalanceViewModelTest: PresentDepositOptions always routes through the add-money deposit sheet (AddMoneyUX). - BalanceScreenContentTest: empty wallet shows the "Add Money" CTA and never the old "Discover Currencies" fallback; tapping it opens deposit options. - LoginViewModelPhoneVerificationTest: phone verification is gated only by whether a verified phone is linked (OnboardingPhoneVerification/PhoneNumberSend). Expose BalanceScreenContent as internal for the Robolectric UI test, matching the existing *ScreenContentTest pattern.
github-actions
Bot
added
the
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audits the Android beta/feature flags and retires every flag marked
launched = true. A launched flag already returnstrueunconditionally at runtime (the controller short-circuits it), so removing it and inlining the always-on path is behavior-preserving cleanup — no user-visible change.14 flags removed:
WelcomeBonusBill,Pools,OnRamp,BillCustomizer,CurrencyCreator,CashReserves,MarketCapChart,CoinbaseOnRamp,TokenDiscovery,DepositUsdc,PhoneNumberSend,OnboardingPhoneVerification,Messenger,AddMoneyUX.Kept (still genuinely in-flight):
CredentialManager,VibrateOnScan,TransactionDetails,CoinbaseOnRampSandbox,BillTextures,BackgroundReset,ContactPickerMode,GiveUsdf,NavBar,ShowNetworkState,Tipping,FrostedTipCard,Blocklist.Commits
refactor: inline launched beta flags at call sites— every consumer treats the flag as always-on: deadif (flag)/elsebranches collapsed, constant state fields removed and their observe/event/reducer plumbing deleted, always-on values propagated into the UI, and now-unusedFeatureFlagControllerdependencies dropped. Also removes the dead server-flag OR (flag || enablePhoneNumberSend, always true) andRealChatCoordinator's redundant flag observer. (Flags still defined here → compiles.)chore: remove launched beta flag definitions— deletes the 14data objects and theirtitle/messageentries fromFeatureFlag.kt. (No references remain → compiles.)Notable structural cleanups
SessionState.addMoneyUxandSessionState.isPhoneNumberSendEnabled(+ updatedSessionStateHolderTest).RealChatCoordinator.observeFeatureFlag()/isChatEnabled()— redundant with the unconditional login sync.if (chartEnabled)inMarketCapSectionand the add-money branches across Swap/Token/Menu/Balance/Chat flows.description_noBalanceYetDiscoverstring.Testing
./gradlew :apps:flipcash:app:assembleDebug→ BUILD SUCCESSFUL:apps:flipcash:shared:session+:apps:flipcash:shared:featureflagsunit tests → pass