Skip to content

feat(wallet-mcp): move wallet-mcp skill from base/skills - #11

Merged
ethanoroshiba merged 2 commits into
coinbase:mainfrom
bruno-barbieri-cb:feat/wallet-mcp-skill
Oct 26, 2026
Merged

ethanoroshiba merged 2 commits into
coinbase:mainfrom
bruno-barbieri-cb:feat/wallet-mcp-skill

Conversation

@bruno-barbieri-cb

@bruno-barbieri-cb bruno-barbieri-cb commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

Moves the wallet-mcp skill from base/skills to skills/wallet-mcp/ in this repo. Jazz (CDP) confirmed coinbase/agents as the destination for the Base MCP to CDP handoff, and this needs to land before the headless GTM.

Layout matches the repo convention (skills/<product>/SKILL.md, no extra container): SKILL.md, README.md (disclaimer), references/ (7 guides), and plugins/ (21 third-party plugin guides). 28 files, contents unchanged except:

  • "Base MCP" renamed to "Wallet MCP" (13 occurrences, per Bruno). The base-mcp strings used as attribution identifiers in plugins/kyberswap.md and plugins/clawnch.md (source / x-client-id values sent to third-party APIs) and the deprecated-skill note in references/plugin-spec.md are intentionally left as-is.
  • Install command in SKILL.md now reads npx skills add coinbase/agents --skill wallet-mcp.
  • Three markdown placeholders that the repo's link validator treats as broken relative links were reworded: [Approve Transaction](approvalUrl) in plugins/o1-exchange.md, and [Approve Transaction](URL) x2 in references/approval-mode.md (now https://<approval-url>).
  • README product table and CHANGELOG entry added; tests/test_coinbase_products.py SKILL.md inventory now includes wallet-mcp/SKILL.md.
  • Operator wording: the disclaimer (README.md) and the onboarding disclaimer and plugin note (SKILL.md) now name Coinbase Wallet instead of Base as the operator, "Base Account" becomes "Coinbase Wallet Account", and the terms link reads "Coinbase Wallet Terms of Service" (same URL, https://wallet.coinbase.com/terms-of-service). References to Base the chain are unchanged.

Provenance: the skill was added to base/skills in base/skills#169 ("Add wallet-mcp skill (rename of base-mcp, multi-chain)", single commit by bruno-barbieri-cb). History is not carried over; this is a copy. The base/skills copy is left in place and will be removed separately after this merges.

Source only: not added to the shared coinbase router, COINBASE_SKILL_PRODUCTS, or any generated distribution, and no MCP configuration changes. Shipping it in a distribution is a follow-up that needs the product selection and approved client/MCP config updated together.

Change type

  • Harness integration or metadata
  • Skill workflow
  • Bug fix
  • Documentation
  • Breaking change (describe migration)

Validation

Passed locally:

  • python3 -m unittest discover -s tests (33 tests; baseline on main also 33 passing)
  • uvx ruff@0.13.2 check and format --check on scripts/build-distributions.py and tests
  • python3 scripts/build-distributions.py dist builds all four distributions; SHA256SUMS verifies; the generated packages still contain exactly coinbase, coinbase-cli, coinbase-mcp
  • Repo link validator (validate_links) passes on the new skill; git diff --check clean
  • Scanned the skill files for credentials and internal references (hostnames, Slack/doc links, emails): none found. Hits for "token"/"API key" are protocol prose and env-var names only, no values.

Not run: native harness activation in Claude Code, Codex, Cursor, Hermes, or ChatGPT; OAuth; authenticated Wallet MCP calls; any financial operation. The CI schema check (check-jsonschema) was not run locally because this PR does not touch plugin manifests or MCP config.

  • Generated portable manifest and MCP config validate against the vendored Agent Plugins schemas (N/A: no manifest or MCP changes)
  • Package paths and skill references remain inside each generated plugin root (N/A: skill not packaged yet)
  • Marketplace, skills, MCP, and icon paths are valid (N/A: no changes)
  • Exactly one canonical skill library; generated copies are not committed
  • Claude compatibility metadata/endpoint and marketplace sources agree with the portable package (N/A: no changes)
  • Tool schemas, authorization, and retry behavior reviewed (moved as-is; no re-audit, see below)
  • README and changelog updated; versions consistent
  • No unapproved disclosures or sensitive data
  • Signed commits

The skill's tool guidance, approval flow, and per-plugin safeguards are preserved from base/skills apart from the edits above. Maintainers should review the third-party plugin guides and the disclaimer in README.md against CONTRIBUTING's licensing, branding, and legal requirements before any distribution includes this skill. Legal sign-off on the headless signing model is separate from this move.

Release considerations

  • Not shipped in any distribution by this PR; no version bump needed beyond the existing unreleased 0.0.1 changelog entry.
  • Follow-ups: remove or redirect the skill in base/skills after merge; decide router and distribution inclusion, and MCP endpoint config for Wallet MCP (wallet-mcp.coinbase.com).
  • Opened from a fork (bruno-barbieri-cb/agents) because the author has no write access to this repo.

Move the wallet-mcp skill (SKILL.md, README.md, 7 references, plugin
files) from base/skills (introduced in base/skills#169) to
skills/wallet-mcp/ in this repo. Destination confirmed by Jazz (CDP).

Changes required by the new location:
- Rename "Base MCP" to "Wallet MCP" in skill text (13 occurrences).
  Plugin attribution identifiers (`base-mcp` source/client-id values)
  are left as-is because third-party APIs key off them.
- Point the install command at coinbase/agents.
- Replace two placeholder link targets (`approvalUrl`, `URL`) that the
  repo's local link validator treats as broken relative links.
- Add the skill to the README product table and CHANGELOG, and allow it
  in the SKILL.md inventory test.

Source only: not added to the shared router, COINBASE_SKILL_PRODUCTS, or
any generated distribution. base/skills copy is left in place.

Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@cb-heimdall

cb-heimdall commented Oct 20, 2026 •

Copy link
Copy Markdown

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@bruno-barbieri-cb

Copy link
Copy Markdown
Contributor Author

@ethanoroshiba could you review this when you get a chance? It moves the wallet-mcp skill over from base/skills, per the CDP handoff (Jazz confirmed this repo as the destination). I couldn't add you as a formal reviewer because I only have fork access.

ethanoroshiba

This comment was marked as outdated.

Replace "Base" as the operating party with "Coinbase Wallet" in the
disclaimer (README.md) and onboarding text (SKILL.md), and point the
terms link at the "Coinbase Wallet Terms of Service". Wording only.

Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@ethanoroshiba
ethanoroshiba merged commit e13333e into coinbase:main Oct 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants