Repository navigation
feat(wallet-mcp): move wallet-mcp skill from base/skills - #11
Merged
ethanoroshiba merged 2 commits intoOct 26, 2026
Merged
Conversation
Move the wallet-mcp skill (SKILL.md, README.md, 7 references, plugin files) from base/skills (introduced in base/skills#169) to skills/wallet-mcp/ in this repo. Destination confirmed by Jazz (CDP). Changes required by the new location: - Rename "Base MCP" to "Wallet MCP" in skill text (13 occurrences). Plugin attribution identifiers (`base-mcp` source/client-id values) are left as-is because third-party APIs key off them. - Point the install command at coinbase/agents. - Replace two placeholder link targets (`approvalUrl`, `URL`) that the repo's local link validator treats as broken relative links. - Add the skill to the README product table and CHANGELOG, and allow it in the SKILL.md inventory test. Source only: not added to the shared router, COINBASE_SKILL_PRODUCTS, or any generated distribution. base/skills copy is left in place. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
✅ Heimdall Review Status
|
Contributor
Author
|
@ethanoroshiba could you review this when you get a chance? It moves the wallet-mcp skill over from base/skills, per the CDP handoff (Jazz confirmed this repo as the destination). I couldn't add you as a formal reviewer because I only have fork access. |
Replace "Base" as the operating party with "Coinbase Wallet" in the disclaimer (README.md) and onboarding text (SKILL.md), and point the terms link at the "Coinbase Wallet Terms of Service". Wording only. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
ethanoroshiba
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
wallet-mcpskill frombase/skillstoskills/wallet-mcp/in this repo. Jazz (CDP) confirmedcoinbase/agentsas the destination for the Base MCP to CDP handoff, and this needs to land before the headless GTM.Layout matches the repo convention (
skills/<product>/SKILL.md, no extra container):SKILL.md,README.md(disclaimer),references/(7 guides), andplugins/(21 third-party plugin guides). 28 files, contents unchanged except:base-mcpstrings used as attribution identifiers inplugins/kyberswap.mdandplugins/clawnch.md(source/x-client-idvalues sent to third-party APIs) and the deprecated-skill note inreferences/plugin-spec.mdare intentionally left as-is.SKILL.mdnow readsnpx skills add coinbase/agents --skill wallet-mcp.[Approve Transaction](approvalUrl)inplugins/o1-exchange.md, and[Approve Transaction](URL)x2 inreferences/approval-mode.md(nowhttps://<approval-url>).tests/test_coinbase_products.pySKILL.md inventory now includeswallet-mcp/SKILL.md.README.md) and the onboarding disclaimer and plugin note (SKILL.md) now name Coinbase Wallet instead of Base as the operator, "Base Account" becomes "Coinbase Wallet Account", and the terms link reads "Coinbase Wallet Terms of Service" (same URL,https://wallet.coinbase.com/terms-of-service). References to Base the chain are unchanged.Provenance: the skill was added to
base/skillsin base/skills#169 ("Add wallet-mcp skill (rename of base-mcp, multi-chain)", single commit by bruno-barbieri-cb). History is not carried over; this is a copy. Thebase/skillscopy is left in place and will be removed separately after this merges.Source only: not added to the shared
coinbaserouter,COINBASE_SKILL_PRODUCTS, or any generated distribution, and no MCP configuration changes. Shipping it in a distribution is a follow-up that needs the product selection and approved client/MCP config updated together.Change type
Validation
Passed locally:
python3 -m unittest discover -s tests(33 tests; baseline onmainalso 33 passing)uvx ruff@0.13.2 checkandformat --checkonscripts/build-distributions.pyandtestspython3 scripts/build-distributions.py distbuilds all four distributions;SHA256SUMSverifies; the generated packages still contain exactlycoinbase,coinbase-cli,coinbase-mcpvalidate_links) passes on the new skill;git diff --checkcleanNot run: native harness activation in Claude Code, Codex, Cursor, Hermes, or ChatGPT; OAuth; authenticated Wallet MCP calls; any financial operation. The CI schema check (
check-jsonschema) was not run locally because this PR does not touch plugin manifests or MCP config.The skill's tool guidance, approval flow, and per-plugin safeguards are preserved from
base/skillsapart from the edits above. Maintainers should review the third-party plugin guides and the disclaimer inREADME.mdagainst CONTRIBUTING's licensing, branding, and legal requirements before any distribution includes this skill. Legal sign-off on the headless signing model is separate from this move.Release considerations
0.0.1changelog entry.base/skillsafter merge; decide router and distribution inclusion, and MCP endpoint config for Wallet MCP (wallet-mcp.coinbase.com).bruno-barbieri-cb/agents) because the author has no write access to this repo.