Repository navigation
Return an empty string instead of asserting in clang-repl toString - #1170
Open
manpreetsinghraina191-rgb wants to merge 1 commit into
Open
manpreetsinghraina191-rgb wants to merge 1 commit into
manpreetsinghraina191-rgb wants to merge 1 commit into
Conversation
Interpreter::toString was an assert(0) stub on the clang-repl path, so Cpp::ObjToString aborted with assertions enabled and silently returned "" without them. Return "" in every build and document it as "no string representation", so callers can fall back instead of crashing. Fixes compiler-research#1100.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100.
Interpreter::toStringon the clang-repl path was anassert(0)stub, soCpp::ObjToStringaborted when assertions were enabled and silently returned""when they weren't.This PR follows the interim approach discussed in the issue: report failure instead of asserting, so callers such as cppjit's
op_strcan fall back.toStringnow returns""in every build. AFIXMEnotes that it should move to clang-repl's value printer once that supports user-defined types; upstream still hasFIXME: Add support for user defined printers.ObjToString's docs now state that""means there is no string representation, which is always the case under clang-repl.Interpreter_ObjToStringtest. It expects""under clang-repl and a non-empty string under Cling.The public signature is unchanged, so existing callers aren't affected.
Open question: should
ObjToStringeventually returnCpp::Result<std::string>? I left that out because no public API usesResult<T>yet, and it seemed like a call for the error-model work rather than this fix.