Repository navigation
llvm-wasm: install the wasm tree in the environment it was built in. - #157
Merged
Merged
Conversation
CppInterOp's Windows emscripten row fails to link against the LLVM 23 cell built with emsdk 6.0.8: LLVM ERROR: Function ..CrashRecoveryContext9RunSafely.. is using setjmp/longjmp but does not have +exception-handling target feature The Windows llvm-wasm artifacts are built without wasm exception handling: CrashRecoveryContext.cpp.o in their libLLVMSupport.a carries no +exception-handling, the Linux one does. Every windows-2025 cell is affected; emsdk 6.0.8 is the first link to need it. The wasm targets are built under emmake with EMCC_CFLAGS=-fwasm-exceptions, in the environment emsdk_env() makes. On Windows that environment moves the ccache launcher from CMAKE_<LANG>_COMPILER_LAUNCHER to EM_COMPILER_WRAPPER, so the tree is configured without one. The install that follows reconfigures in the job's own environment, where the launcher is still set; cmake picks it up, every compile command changes, and ninja rebuilds 2611 of the 3241 steps through ccache without EMCC_CFLAGS. Those are the objects that ship. On Linux the launcher is in both environments, and the install builds nothing. Run the install in the environment of the build.
emsdk_env() starts from a copy of os.environ, and it was called after os.environ.clear(). The install step then ran with PATH reduced to the two emsdk directories and an empty entry, so cmake was not found: a FileNotFoundError on Windows, and on Linux and macOS a PermissionError from emscripten's cmake/ directory being the only match. Every llvm-wasm cell failed before installing anything. Build the environment first, then replace os.environ with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CppInterOp's Windows emscripten row fails to link against the LLVM 23 cell built with emsdk 6.0.8:
LLVM ERROR: Function ..CrashRecoveryContext9RunSafely.. is using
setjmp/longjmp but does not have +exception-handling target feature
The Windows llvm-wasm artifacts are built without wasm exception handling: CrashRecoveryContext.cpp.o in their libLLVMSupport.a carries no +exception-handling, the Linux one does. Every windows-2025 cell is affected; emsdk 6.0.8 is the first link to need it.
The wasm targets are built under emmake with
EMCC_CFLAGS=-fwasm-exceptions, in the environment emsdk_env() makes. On Windows that environment moves the ccache launcher from CMAKE__COMPILER_LAUNCHER to EM_COMPILER_WRAPPER, so the tree is configured without one. The
install that follows reconfigures in the job's own environment, where the launcher is still set; cmake picks it up, every compile command changes, and ninja rebuilds 2611 of the 3241 steps through ccache without EMCC_CFLAGS. Those are the objects that ship. On Linux the launcher is in both environments, and the install builds nothing.
Run the install in the environment of the build.