Repository navigation
fix: set the Hyper-V UVM memory annotation in MB - #5338
Open
vitaliy-leschenko wants to merge 1 commit into
Open
vitaliy-leschenko wants to merge 1 commit into
vitaliy-leschenko wants to merge 1 commit into
Conversation
`nerdctl run --isolation hyperv --memory` wrote the parsed value in bytes into io.microsoft.virtualmachine.computetopology.memory.sizeinmb, which hcsshim reads as megabytes. With `--memory 2g` the utility VM was requested with 2147483648 MB and creation failed. Fixes containerd#5337 Signed-off-by: Vitaliy Leschenko <v.leschenko@vitaliy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5337
nerdctl run --isolation hyperv --memorywrites the value parsed byunits.RAMInBytes(bytes) intoio.microsoft.virtualmachine.computetopology.memory.sizeinmb, which hcsshim reads as megabytes. With--memory 2gthe utility VM is requested with 2147483648 MB andhcs::CreateComputeSystemfails.This converts the value to MB before setting the annotation.
Testing on Windows Server 2025 with Hyper-V isolation, using a patched build:
--memory 2g: the annotation is2048, and the utility VM has 2047 MB. Unpatched nerdctl fails with the same arguments.--memory 1536m: the utility VM has 1535 MB.GOOS=windows go build ./cmd/nerdctlandgo vet ./pkg/cmd/container/pass. I did not add a unit test, because the value is set inline insetPlatformOptions.