Repository navigation
fix(imgutil): accept leading wildcards in reference filters - #5339
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
Keep valid reference globs when optional regexp parsing fails. Preserve invalid glob errors, regexp matching and all-pattern filtering. Signed-off-by: Peter Olkhovets <peterolkhov@users.noreply.github.com> Assisted-by: Codex (GPT-6.1 Sol, high reasoning)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid reference glob such as
*alpine*passes glob parsing, then fails because it is also parsed as a regular expression. Keep glob matching and use the optional regexp result only when regexp parsing succeeds. Malformed globs still return their original error.Tests cover wildcard match-all, a nonmatching image before the target, no matches, regexp-only matching, invalid syntax, dangling images and multiple-pattern AND behavior. Package tests,
make test-unit,make binaries, four-target Go lint, module lint and formatting passed locally. The CLI integration case compiles; it was not run against a daemon.AI assistance: GPT-6.1 Sol with high reasoning.