test(bindx): fix the chronic author-select flake, capture failure screenshots, cover collectFieldsData

[matej21]

Two test-only changes.

The chronic browser flake

Article with Author Select > changing author enables save and updates display has failed on roughly half of all CI attempts since 2026-08-20, on branches that touch nothing near it — 10 of 18 attempts in one sweep on 2026-08-24, and again today on the merge commit for #89. It has been reading as a regression signal on unrelated PRs.

The popover was opened once, outside the clickUntil retry loop:

el(`${tid('article-with-author-select')} [aria-haspopup="dialog"]`).click()
waitFor(() => janeOption().exists)
clickUntil(() => janeOption(), () => …includes('Jane'))

A click that lands while the option list is remounting is lost and dismisses the popover. From then on janeOption() does not exist, so every remaining attempt throws inside the target callback (swallowed by design) and settles for nothing. The budget burns without a single real try — which is why the failure always costs the full ~15s and why raising the budget would not have helped.

Now the popover is opened inside the retry callback, and only when the option is not already present, so a dismissed popover is reopened instead of toggled shut.

Screenshots on failure

ci.yml has always uploaded /tmp/browser-test-*.png on failure, but nothing in the harness ever called screenshot() — the artifact was empty on every red run, which is part of why this flake stayed unexplained for a week. waitFor now captures on timeout; clickUntil passes capture: false for the intermediate polls it expects to fail and retry.

collectFieldsData cycle coverage

Follow-up to #88. collectFieldsData is the other public entry into relation collection and reaches collectHasOneOperation exactly as collectUpdateData does, so it walks a hasOne cycle and — without the guard from #89 — overflows the stack. It had no coverage because nothing in the persist pipeline routes through it: a fields-scoped persist uses BatchPersister's own scalar-only variant instead. Verified the new case fails with the RangeError when the guard is reverted.

Verification

• bun run test:browser locally: 66 pass / 0 fail; the author-select file alone drops from ~15s worst case to 4s
• screenshot-on-timeout confirmed end to end — a forced timeout produced /tmp/browser-test-<ts>.png and named it in the error
• bun test tests/unit/persistence/relationCycleCollection.test.ts: 4 pass; the new case fails with RangeError against the pre-fix(bindx): stop nested collection recursing through relation cycles #89 collector

Note for a follow-up, not changed here: MutationCollector.collectFieldsData has no caller anywhere in the monorepo.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EmqgPtZvAfpvWKymfFZCEX