Skip to content

URL parameter name may conflict with other modules #12

Description

@TerrapinSoftware

Interesting scenario: We chose "code" for the URL parameter name. Unfortunately, if you create a new email template and load an existing template, the POST request uses the same parameter name. This causes an error message "Discount code XXX is invalid", where XXX is the ID code of the loaded template. Of course, because there is no such discount code. Triggered in FrontControllerInterface.php line 227.

Maybe is would be a good idea to limit the detection of URL parameters to GET requests, and to make sure that the area code is not "adminhtml". The short-term remedy is to use a unique name for the URL parameter, which could be a problem.

This was with Magento 2.4.2-p2 and 2.4.3.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions