Repository navigation
Conversation
related API issue. Fixes: #134
gyptazy
force-pushed
the
fix/134-reevaluate-on-api-error
branch
from
September 16, 2026 13:10
3d2e2bf to
c334e30
Compare
Collaborator
Author
|
Testrun by killing a single node during runtime: During API connection handlingDuring runtime where a nods becomes unavailable |
Collaborator
Author
|
The second part is now also included where it checks if the node count changed during migrations which could lead into imbalances and starts the calculations from scratch: |
dlucredativ
reviewed
Sep 17, 2026
| # every connect) and reconnect from scratch, re-running host failover. | ||
| proxlb_config = config_parser.get_config() | ||
| logger.set_log_level(proxlb_config.service.log_level) | ||
| proxmox_api = ProxmoxApi(proxlb_config) |
Contributor
There was a problem hiding this comment.
Assuming someone has only one endpoint configured, and that endpoint is rebooting. Is ProxLB supposed to sys.exit(2) then?
And with multiple endpoints, it is possible that ProxmoxApi exits e.g. because of SSLError of a single random endpoint.
Collaborator
Author
|
Hey @dlucredativ, thanks for your time and efforts you took into this review. Good catches! I've adjusted the mentioned things and revalidated them on my cluster. Cheers, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Reevaluate and restart the run when there is a connection related API issue.
Fixes: #134