Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proxmox VE serializes VM and container tags as comma-separated lists (
tags: tag1,tag2,tag3) in guest configurations and API responses.Currently,
Tags.get_tags_from_guestssplits only on semicolons (;), causing comma-separated tag lists to be ingested as a single unparsed string. Consequently, any tags after the first (includingplb_affinity_*,plb_anti_affinity_*,plb_pin_*, andplb_ignore_*) fail prefix matching and are silently ignored.Solution
Update
Tags.get_tags_from_gueststo split on[,;\s]+, supporting:,);)Added unit tests in
tests/test_tags.pycovering QEMU and LXC guests with comma, semicolon, and spaced tags.