Repository navigation
Conversation
…ns from non-peak nodes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calculations.val_anti_affinityusedused_nodeswhich starts empty and only recorded nodes chosen during the current relocation run. It did not check the existing locations of other members in the anti-affinity group, allowing guests to be assigned to nodes already hosting another member of the group.Calculations.relocate_guestsunconditionally broke out of the guest relocation loop if the guest's source node was not the highest-loaded node in the cluster (highest_node.name != source_node). If anti-affinity group members were co-located on a non-peak node, ProxLB would never move them to resolve the violation.Solution
occupied_nodesinval_anti_affinitywith the current or target nodes of all other members of the anti-affinity group before choosing an assignment.highest_node != source_nodeearly-exit whenenforce_affinityis active.Added unit tests in
tests/test_calculations_anti_affinity_relocation.pyvalidating anti-affinity target selection and non-peak node relocation.