Skip to content

fix(connection): update invalid connectionId error message - #1767

Open
Aadiii00 wants to merge 1 commit into
credebl:mainfrom
Aadiii00:fix/1229-connection-id-error
Open

Aadiii00 wants to merge 1 commit into
credebl:mainfrom
Aadiii00:fix/1229-connection-id-error

Conversation

@Aadiii00

@Aadiii00 Aadiii00 commented Oct 1, 2026 •

Copy link
Copy Markdown

Fixes an issue where providing a space or invalid format in the connectionId parameter returned "Invalid format for connectionId" instead of "Please provide valid connectionId".

Changes

  • Updated invalidConnectionId message in libs/common/src/response-messages/index.ts to match the expected format used across other ID params.
  • Added a unit test to check the error message.

Testing

Ran pnpm jest libs/common/src/response-messages/response-messages.spec.ts - test passed.

Closes #1229

Summary by CodeRabbit

  • Updates
    • Revised the error message shown when a connection ID is invalid.

Signed-off-by: Aadiii00 <adityapammannavaryt@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b6750f6a-4253-4cde-873e-e7000ceb99fb

📥 Commits

Reviewing files that changed from the base of the PR and between 3046294 and 5d5e3e1.

📒 Files selected for processing (2)
  • libs/common/src/response-messages/index.ts
  • libs/common/src/response-messages/response-messages.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The invalid connection ID error message changes to “Please provide valid connectionId.” A test checks that the response message uses this text.

Changes

Connection ID error response

Layer / File(s) Summary
Update and test the error message
libs/common/src/response-messages/index.ts, libs/common/src/response-messages/response-messages.spec.ts
The invalid connection ID message changes to “Please provide valid connectionId.” A test asserts the updated message.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 5d5e3

The requested invalid-connection-ID message is updated and tested. No concrete issue remains that warrants delaying the change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the invalid connectionId error message.
Linked Issues check ✅ Passed The PR changes connection.error.invalidConnectionId to Please provide valid connectionId, which matches issue #1229. It also adds a unit test for the new message. The reported Jest test passed.
Out of Scope Changes check ✅ Passed The changes are limited to the connection ID error message and its unit test. Both changes directly support issue #1229.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Incorrect error message when space is provided in 'connectionId' parameter

1 participant