Conversation
…n error Signed-off-by: Aadiii00 <adityapammannavaryt@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1225
Description
When calling
POST /v1/orgs/{orgId}/credentials/bulk/templatewith invalid or emptytemplateId/schemaType, the endpoint returned a file download (schema.csv) containing the error message rather than returning a standard JSON 400 Bad Request response.This occurred because static
@Header('Content-Disposition', ...)decorators at the controller method level forced attachment headers on all responses, including validation failures. Additionally,templateIdhad@IsOptional(), which interfered with validation.This PR removes the static
@Headerdecorators in favor of dynamic response headers on success and ensuresTemplateDetailsenforces requiredtemplateIdand validschemaType.Changes
@Headerdecorators fromdownloadBulkIssuanceCSVTemplateinissuance.controller.tsand set dynamic headers on successful CSV export.@IsOptional()fromtemplateIdinTemplateDetails(issuance.dto.ts).template-details.dto.spec.tscovering valid, empty, whitespace-only, and omitted parameter validation.