Repository navigation
docker/zig.sh: restore the executable bit - #1817
Merged
Merged
Conversation
cross-rs#1805 changed the file mode from 100755 to 100644, so `RUN /zig.sh` in docker/Dockerfile.zig fails with `/bin/sh: 1: /zig.sh: Permission denied`.
Member
|
/ci try --tests zig --none |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
duh, zig is a target... totally not confusing /ci try -t zig |
This comment has been minimized.
This comment has been minimized.
Try run for comment
Successful Jobs
|
Emilgardis
approved these changes
Oct 31, 2026
Emilgardis
added
the
no-ci-targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1805 accidentally changed
docker/zig.shfrom 100755 to 100644, so thezigimage has failed to build on every push tomainsince that merge (first run, latest run):This restores the mode and changes nothing else.
PR CI doesn't build this image, so I ran the
zigjob's steps on my fork at d5a5ead: it fails without this change and passes with it, through "Test Zig Image".Disclosure: this commit and description were written by an AI coding agent (Claude Code), the same tool that built #1805's branch, where a hard-coded file mode dropped the bit. It's a one-bit change, so feel free to close this and make it yourself if you'd rather not take AI-written text.