Skip to content

feat(distributions): add release error details - #407

Merged
andrii-bodnar merged 2 commits into
crowdin:mainfrom
hamdiakin:feature/distribution-release-error
Sep 17, 2026
Merged

andrii-bodnar merged 2 commits into
crowdin:mainfrom
hamdiakin:feature/distribution-release-error

Conversation

@hamdiakin

Copy link
Copy Markdown
Contributor

Summary

  • add optional error details to file-based and string-based distribution release models
  • expose the API-provided failure message through a shared response model
  • add response parsing coverage for both distribution types

Tests

  • dotnet build src/Crowdin.Api/Crowdin.Api.csproj -c Release --no-restore
  • env TZ=UTC dotnet test tests/Crowdin.Api.UnitTesting/Crowdin.Api.UnitTesting.csproj -c Release --no-restore (480 passed)

Closes #406

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

Pull request overview

Adds optional API failure details to file-based and string-based distribution release models.

Changes:

  • Adds shared DistributionReleaseError model.
  • Adds nullable error properties to both release models.
  • Adds response parsing tests.
File summaries
File Summary
tests/Crowdin.Api.UnitTesting/Tests/Distributions/DistributionsApiTests.cs Tests error response parsing.
src/Crowdin.Api/Distributions/DistributionStringBasedRelease.cs Adds release error details.
src/Crowdin.Api/Distributions/DistributionReleaseError.cs Defines the shared error model.
src/Crowdin.Api/Distributions/DistributionRelease.cs Adds release error details.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Crowdin.Api/Distributions/DistributionStringBasedRelease.cs Outdated
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.79%. Comparing base (f45d418) to head (3052ee9).
⚠️ Report is 205 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #407       +/-   ##
===========================================
+ Coverage   50.38%   72.79%   +22.41%     
===========================================
  Files         277      486      +209     
  Lines        3688     7704     +4016     
  Branches        0      627      +627     
===========================================
+ Hits         1858     5607     +3749     
- Misses       1830     2041      +211     
- Partials        0       56       +56     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrii-bodnar
andrii-bodnar merged commit e1914ed into crowdin:main Sep 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add error details to Distribution Release responses

3 participants