Repository navigation
feat(distributions): add release error details - #407
Merged
andrii-bodnar merged 2 commits intoSep 17, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Adds optional API failure details to file-based and string-based distribution release models.
Changes:
- Adds shared
DistributionReleaseErrormodel. - Adds nullable error properties to both release models.
- Adds response parsing tests.
File summaries
| File | Summary |
|---|---|
tests/Crowdin.Api.UnitTesting/Tests/Distributions/DistributionsApiTests.cs |
Tests error response parsing. |
src/Crowdin.Api/Distributions/DistributionStringBasedRelease.cs |
Adds release error details. |
src/Crowdin.Api/Distributions/DistributionReleaseError.cs |
Defines the shared error model. |
src/Crowdin.Api/Distributions/DistributionRelease.cs |
Adds release error details. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
===========================================
+ Coverage 50.38% 72.79% +22.41%
===========================================
Files 277 486 +209
Lines 3688 7704 +4016
Branches 0 627 +627
===========================================
+ Hits 1858 5607 +3749
- Misses 1830 2041 +211
- Partials 0 56 +56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrii-bodnar
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Closes #406