Skip to content

Rewrite Gamma services in Kotlin - #973

Closed
Portals wants to merge 2 commits into
mainfrom
kotlin-refactor
Closed

Portals wants to merge 2 commits into
mainfrom
kotlin-refactor

Conversation

@Portals

@Portals Portals commented Aug 20, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@Portals
Portals requested a review from Goosetaf as a code owner August 20, 2026 16:42
@Portals

Portals commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

This has bee rewritten in various goals using Codex and GPT 5.6 Sol.

Going to start reviewing the code all and all.

@olillin

olillin commented Sep 2, 2026

Copy link
Copy Markdown

These security improvements and features sound great but was there a need for such a massive architecture shift? It seems quite tiresome to review a PR which quintuples the line count of the repository. More than that though it makes me quite nervous that something would break silently, especially since Gamma is such a central part of the division's systems

@Portals

Portals commented Sep 3, 2026 •

Copy link
Copy Markdown
Member Author

@olillin I'm confident in the result of this rewrite. And I'm confident that it will lead to better Gamma. It should however be in draft still, I'm starting to land on an architecture I like.

I will also deploy 2.5.1 first on railway, along with chalmers.it and bookit. Then, I will upgrade to 2.6.0 to make sure the migration is smooth.

@Portals
Portals marked this pull request as draft September 3, 2026 20:26
Retain typed Exposed queries while making transaction ownership, cross-context participation, and external effects explicit. Remove forwarding layers, fix allow-list commit outcomes, and cover operation guarantees with PostgreSQL integration tests.

Verified with 585 JVM tests, 54 Chromium browser tests, full lint and formatting checks, context boundaries, coverage thresholds, and a production image build.
@Portals

Portals commented Sep 7, 2026 •

Copy link
Copy Markdown
Member Author

I will close this PR.

I had a lot of fun working through many different refactoring, but I think for the best of the project that I keep the incrementing changes instead of the mega rewrite.

For the record, I have full confidence that this rewrite would work, but I do not think it is the best way forward regardless.

@Portals Portals closed this Sep 7, 2026
@Portals
Portals deleted the kotlin-refactor branch September 7, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment