Repository navigation
fix(deploy): the stand's three deploy-script defects, each with a test that fails first (soft3 P3c) - #9
Merged
Conversation
…3c) — red until the fixes run-node.sh must find cybernode-check beside it (README installs both in bin/), udp_bound must read ss -uln without a Netid column, and ufw-chain.sh present() must match plain ufw status (ALLOW, no IN). Each test sources or runs the real script text; the workflow runs them on every deploy/ change.
…ithout Netid, ufw present() matches plain status The defects the owner hit on the stand (soft3#493, 2026-11-01 20:11 UTC): run-node.sh fell back to ../cybernode-check while the README installs the check in bin/ beside it; udp_bound took $5 of ss -uln, which has no Netid column with one protocol, so a bound radio reported DOWN; present() grepped ALLOW IN, which only ufw status verbose prints, so close said not open.
cyberia-apparatus
marked this pull request as ready for review
November 2, 2026 02:23
Collaborator
Author
|
Receipts (build service, workflow
The director reviewed the diff against plan row P3c. A sonnet subagent implemented the first version. The director replaced its ufw test, which at the old script failed on the hard-coded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
soft3 plan P3c: the three defects in the stand's deploy scripts that the owner hit (soft3#493, 2026-11-01 20:11 UTC, deviations 2–4). This is a bug fix with failing tests, so it may merge in the freeze.
deploy/chain/agent-a/run-node.sh: withSOFT3_CHECKunset and nocybernode-checkonPATH, the script fell back to$here/../cybernode-check. The README installs the check inbin/next to the script, so the fallback missed it (the owner's workaround on agent-a wasSOFT3_CHECK=). The order is nowSOFT3_CHECK,PATH,cybernode-checknext to the script, then../cybernode-check, so running in place from the repo still works. The README states the same order.deploy/chain/cybernode-checkudp_bound: the function read$5ofss -uln. With one protocol,ssprints no Netid column, so a bound radio reportedDOWN radio. It now matches any field that ends in[:.]PORT, which works with or without the Netid column. The peer column (*) never matches.deploy/chain/ufw-chain.shpresent(): it greppedALLOW IN, which onlyufw status verboseprints. With plain status,closesaid "not open" andopenadded a duplicate rule. It now matchesALLOW(\s+IN)?.deploy/chain/tests/holds one bash test per defect plusrun.sh. Each test runs or sources the real text from the script. The new workflow.github/workflows/deploy-tests.ymlruns them on every change underdeploy/.Verified
6e256a0(tests only, scripts as at645ac7f): red in this PR's CI, receipt below. Locally all three fail for their own reason:cybernode-check next to run-node.sh was not used,no-netid: 7793 should be bound,plain: 7793/udp should be present.53bf05a(the fixes): green in this PR's CI, receipt below.bash -nis clean on all three scripts.Remains
The soft3 cybernode pin bump after the merge.
Risk
Low, and confined to the deploy scripts. The
udp_boundandpresent()matches are wider than before:present()also matches the verbose form, and the tests cover both forms.🤖 Generated with Claude Code