Repository navigation
Migrate Browser Wrangler to Native AOT - #29
Merged
Merged
Conversation
Switch app and release pipeline from partial trim/ReadyToRun to Native AOT, including CI AOT publish validation on dev PRs. Replace System.Drawing icon extraction with Win32 APIs for AOT compatibility and move Firefox SQLite reads to winsqlite3 provider initialization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Migrates Browser Wrangler from ReadyToRun to Native AOT to improve cold-start performance.
Changes:
- Enables Native AOT publishing and CI validation.
- Replaces non-AOT-compatible icon and SQLite dependencies.
- Updates diagnostics and documentation.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
IconLoader.cs |
Replaces System.Drawing icon extraction with Win32 APIs. |
DiagnosticsInfo.cs |
Uses assembly metadata for SDK version fallback. |
PickerWindow.xaml.cs |
Accepts generalized image sources. |
BrowserWrangler.csproj |
Enables Native AOT and removes System.Drawing. |
FirefoxProfiles.cs |
Initializes the Windows SQLite provider. |
BrowserWrangler.Core.csproj |
Uses AOT-compatible SQLite packages. |
README.md |
Documents Native AOT releases. |
release.yml |
Publishes Native AOT release artifacts. |
ci.yml |
Validates AOT publishing for x64 and ARM64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use DrawIconEx-to-DIB rasterization in IconLoader so transparency/mask semantics are applied correctly and avoid GetDIBits source-selection pitfalls. Add shared SqliteProviderBootstrap and invoke it in both production and tests before opening SQLite connections. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Browser Wrangler is a short-lived on-demand app, so startup cost matters. This migrates the app and release pipeline from ReadyToRun/partial trim to Native AOT to reduce cold-start overhead and remove runtime JIT dependency.
What changed
IsAotCompatible,PublishAot,AllowUnsafeBlockswhere required by CsWinRT analyzer).System.Drawing.Commonicon extraction with Win32-based extraction (SHGetFileInfo+ bitmap conversion toWriteableBitmap) to avoid non-AOT-safe APIs.Microsoft.Data.Sqlite.Core+SQLitePCLRaw.provider.winsqlite3, with explicit one-time provider initialization.dev.PublishAot=trueinstead ofPublishReadyToRun=true.Notes
windows-latestis configured to validate publish in automation.devis intentional for the requested channel target.