common: add a new literal + fix warnings - #46
Merged
Merged
Conversation
janekmi
force-pushed
the
janekmi/scans-fix
branch
from
August 6, 2026 09:29
e67f8b9 to
18c6ba8
Compare
janekmi
marked this pull request as ready for review
August 6, 2026 09:29
janekmi
force-pushed
the
janekmi/scans-fix
branch
from
August 6, 2026 09:31
18c6ba8 to
41318d7
Compare
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
janekmi
force-pushed
the
janekmi/scans-fix
branch
from
August 6, 2026 10:22
3850dd1 to
8bf4cc1
Compare
osalyk
approved these changes
Aug 6, 2026
osalyk
left a comment
osalyk
left a comment
Contributor
There was a problem hiding this comment.
@osalyk reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on grom72).
grom72
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://github.com/daos-stack/pmdk/actions/runs/31089065892/job/92575397177
This change is