Repository navigation
Conversation
Signed-off-by: ep0ll <wygininc@gmail.com>
Signed-off-by: ep0ll <wygininc@gmail.com>
Signed-off-by: ep0ll <wygininc@gmail.com>
ep0ll
marked this pull request as ready for review
November 2, 2026 14:33
1. ensure GetDaprCommand getting evns from envFile 2. ensure RunConfig methods #getEnv #GetEnv retrive expected envs 3. ensure all common envs are propagated to all Apps 4. ensure that app's envFile apply to their respective apps 5. app envs take precedence over common envs when both envFiles have same keys an existing test is failing, which is exected to be fixed bug in this PR Signed-off-by: ep0ll <wygininc@gmail.com>
Signed-off-by: ep0ll <wygininc@gmail.com>
Signed-off-by: ep0ll <wygininc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for loading environment variables from an env file in
dapr run -f(multi-app run). Until now, multi-app run templates only accepted environment variables written inline in the YAML file, so apps that already keep their configuration in.envfiles had to copy it into the template.[envFile]as an option in the multi-app run template, at[app level / common level], pointing to a file ofKEY=VALUEentries.dapr run -flaunches an app, the variables from that file are added to the app's environment alongside any inlineenventries.[inline env overrides envFile / envFile overrides inline env].os.LookupEnv, which wrongly rejected valid configurations.[returns a clear error / is skipped].Issue reference
Please reference the issue this PR will close: #1369
Closes #1369
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: