Repository navigation
fix: URL-encode metadata query parameters in dapr publish - #1745
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Metadata keys and values passed with --metadata were concatenated into the query string without escaping, so values containing &, +, # or spaces reached daprd split, altered or truncated. Build the query with url.Values. Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dapr publish --metadatabuilt the publish query string by concatenatingmetadata.<key>=<value>pairs without escaping. A value containing&,+or#reached daprd split, altered or truncated. For example,&tier=goldin acloudevent.sourceURL became a separatetierparameter, and+in a value became a space.This change builds the query with
url.Values, which encodes keys and values and also sorts the keys, so the generated URL is deterministic. Requests with no metadata are unchanged.A new unit test,
TestGetQueryParamsEncodesSpecialCharacters, decodes the generated query withurl.ParseQueryand checks that every value matches the input. The test fails onmasterand passes with this change.Issue reference
Please reference the issue this PR will close: #1744
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
docs/referenceis unchanged)