perf: emit only changed databricks_tags keys in ALTER SET TAGS - #1667
Open
sd-db wants to merge 3 commits into
Open
perf: emit only changed databricks_tags keys in ALTER SET TAGS#1667sd-db wants to merge 3 commits into
sd-db wants to merge 3 commits into
Conversation
Unchanged desired keys are omitted from the payload; remote-only tags are still never unset.
saishreeeee
approved these changes
Sep 8, 2026
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks_tagsdiffs now put only new or updated keys intoALTER … SET TAGS.SET TAGSupserts listed keys, so server state still converges.Test plan
tests/unit/relation_configs/test_tags.py(includingtest_get_diff__omits_unchanged_keys)databricks_uc_sql_endpoint: incremental tags, table tags, table tags via alter, view tags via alter