Feature/poi support - #79
Merged
Merged
Conversation
6 tasks
adefabian
force-pushed
the
feature/poi_support
branch
2 times, most recently
from
August 13, 2026 13:21
7b92d30 to
328c266
Compare
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
tombonfert
reviewed
Aug 14, 2026
adefabian
force-pushed
the
feature/poi_support
branch
from
August 17, 2026 05:59
59d09ca to
a4fd1d6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 88.99% 89.06% +0.06%
==========================================
Files 61 62 +1
Lines 5199 5360 +161
Branches 627 648 +21
==========================================
+ Hits 4627 4774 +147
- Misses 461 470 +9
- Partials 111 116 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
adefabian
marked this pull request as ready for review
August 17, 2026 12:47
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
tombonfert
reviewed
Aug 18, 2026
Added missing poi in Source Basemodel
Added missing poi in Source Basemodel
Moved POI data check to PointsInTimeSeries
Added missing csv for testing Removed dtype column from csvs
Added value_type to PointsInTimeSerie.empty() so it supports string and double in one place
updated api docs
adefabian
force-pushed
the
feature/poi_support
branch
from
August 20, 2026 06:24
ad4f324 to
767ac6f
Compare
tombonfert
reviewed
Aug 26, 2026
…model and evaluation docs
…re in TSAL core data model docs
…eSeries/PointsInTimeSeries class references
…zation through GROUPED_MAP UDF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Points-in-Time (POI) series as a first-class silver-layer channel type:
a value defined only at its timestamp (no between-point validity), backed by
PointsInTimeSeries, sitting alongside the existing interval-valuedSampleSeries.The motivating case is ECU Diagnostic Trouble Codes (DTCs) — string-valued fault
events analyzed together with continuous signals ("RPM at the instant
DTC == P0301").Changes
poi_channelssilver table (POI_CHANNELS_SCHEMA); series type isdetermined by table membership (
channels⇒ SAMPLE,poi_channels⇒ POI) — noseries_typecolumn needed.PointsInTimeSeriesgains string-value support —==/!=and samplingfor strings; arithmetic/ordering/reductions raise for strings via a
@_numeric_onlyguard; value-type-aware
dtype().QueryBuilder.poi_channel(dtype=...)(accepts the enum or the plainstring
"double"/"string"); the selector carriesseries_type+value_typeandis the plan-time source of truth for series-type dispatch.
_prepare_channels_joinunionspoi_channelsafter RLE encoding(zero-duration points aren't merged);
TimeSeriesCache.load_blobbuilds the rightseries from the selector; a solve-time assertion rejects a declared-vs-actual mismatch.
poi_channels_uriwired throughMeasurementDBConfig,MeasurementDB.poi_channels(), and the reportingSourceconfig.mix-and-match, declared-vs-actual, backward-compat),
PointsInTimeSeriesstringunits,
poi_channel(dtype=...)coercion units, and a config-passthrough regression.reporting_pipeline.ipynbgains a DTC section — freeze-frame (RPM at eachP0301 misfire), per-recording fault counts, and a ±10 s window histogram around faults.
make update-api-docstarget added.Test Plan
Checklist